:bug: Icons not visible in active state with white highlight color

jurialmunkey / skin.arctic.fuse

Other

164 stars 23 forks source link

:bug: Icons not visible in active state with white highlight color #932

Closed Professio73 closed 4 months ago

Professio73 commented 4 months ago

Skin section

Widgets

Current Behavior

In some cases a highlighted square widget doesn't get an inverted icon when the highlight color is set to "white". making the active state unviewable. It works on in certain other widgets but not consistently everywhere.

Expected Behavior

A widget active state should only get a border/outline instead of a complete background highlight if a monochrome (white) color is chosen as a skin highlight color.

Steps To Reproduce

Set "Customise highlight colours" to "White" in "Skin Settings -> Appearance" window
Browse on any view where the "Square" widget is used

Screenshots and Additional Info

It doesn't seem to be an issue with a color or gradient highlight.

Checklist

[X] I have made a separate issue for each bug that I am reporting.
[X] I have searched the issues and this bug has not been reported.
[X] I am using the most recent skin version.
[X] I have confirmed that this bug does not occur in the default skin.

jurialmunkey commented 4 months ago

The above commits should fix up default/genre icon colour inversion on the main layouts, and also the issue with the seams on the selectbox.

There's probably quite a few spots where I've missed including the colour inversion as it won't show up as an issue with other themes (because selected text is white in those and white is the default colour) -- so please let me know any other spots.

Also, side note slightly off topic, but the skin works best if you disable parent folder items. Settings > Media > General > Show parent folder items (disable)

Professio73 commented 4 months ago

Thanks jurialmunkey! Works great now with icons 🙏. I will let you know if i find other spots where it's still an issue.

One thing i noticed however, right on the home screen now, is that poster widgets now get a dark overlay when highlighted. Surprisingly again only when the highlight color "white" is set in the skin settings ...

jurialmunkey commented 4 months ago

One thing i noticed however, right on the home screen now, is that poster widgets now get a dark overlay when highlighted. Surprisingly again only when the highlight color "white" is set in the skin settings ...

Ah, I forgot that this was the issue originally with inverting the icon colour for default icons, which is why I didn't do it originally. I will have to consider a different approach.

jurialmunkey commented 4 months ago

Above undoes the change for default icons. It will still work for genres/countries/studios icons but the default "node" type icons will need a different approach.