OfficerKD637
commented
3 months ago EDIT: Sorry I'm a dumbass haha. Don't even need to touch any other files except the Timers.xml.
I think just adding these lines
<onstart condition="Container(301).OnNext"></onstart>
<onstop condition="!Window.IsVisible(DialogVideoInfo.xml)">Action(Stop)</onstop>
and deleting line 11 should do the job and accomodate (hopefully) all the different scenarios.
And also
<!-- Restart trailer if stopped partially when scrolling through spotlight -->
<onstop condition="!Window.IsVisible(DialogVideoInfo.xml) + Player.HasVideo + String.IsEqual(Window(Home).Property(PlayTrailer),Player.FileNameAndPath)">ClearProperty(PlayTrailer,Home)</onstop>
<onstop condition="!Window.IsVisible(DialogVideoInfo.xml) + Player.HasVideo + String.IsEqual(Window(Home).Property(PlayTrailer),Player.FileNameAndPath)">ClearProperty(PlayTrailerTitle,Home)</onstop>
for when scrolling through the spotlight and the auto trailer kicks in but you go to the next movie before the trailer finishes. Now before the auto trailer for the new movie can start you go back to the previous one but now the auto trailer won't start (because no ClearProperty was set last time when media playback was stopped).
These edits will maintain the trailer playback continuity throughout switching between Spotlight and Info Windows (even clicking the Trailer button in the Info page is accounted for). Once you click on the arrow buttons in the Spotlight, it'll stop the trailer and go to the next item in the carousel (or you can also manually stop the trailer by clicking on the stop button in the Trailer Dialog Window).
Note: If you watch a trailer all the way through in the Spotlight or Info, it won't restart the trailer unless you start a different one.
Optional: check this comment for an additional fix.
I don't know if this is the most "correct" way of solving the problem but please let me know what you think! I have been able to learn a lot from your explanations about why you fix the bugs the way you do (but I really hope I am not bothering you too much haha).
Also, @jurialmunkey I had a question if you don't mind. I know you have repeatedly said that Kodi always overrides back when a video is playing to make it full screen, but I noticed in these last few versions (after Timers.xml was implemented and Alarms were removed) if you go to the Info page of any item and the auto trailer starts playing (regardless of the item belonging in the Spotlight or even in any of your normal widgets) and you hit back, it takes you back to the home screen. Doesn't maximize the video!
It only maximizes the video if you hit back when the trailer is playing in the Spotlight, but just for a second and then goes back to the first item in the spotlight.
I think the move to Timers.xml has added a lot of hidden enhancements haha.
jurialmunkey
vella9
Skin section
Widgets
Current Behavior
On 0.7.20, when trying to toggle trailer to fullscreen by pressing Trailer button in the information page, I am getting a black window/screen and the buttons to toggle fullscreen, stop and pause are not visible anymore as they used to before.
Expected Behavior
trailer should resume in the window that pops up and buttons should be available once more to toggle fullscreen, pause or stop trailer.
Steps To Reproduce
as per Current Behavior
Screenshots and Additional Info
No response
Checklist