jurialmunkey / skin.arctic.fuse

Other
143 stars 21 forks source link

:bug: Latest commit to allow Large Text vs Small Logo is breaking Clear Logo in the Discover hub #968

Closed OfficerKD637 closed 1 week ago

OfficerKD637 commented 2 weeks ago

Skin section

Widgets

Current Behavior

If you have Clearlogo enabled plus either of the text settings (large text + no logo OR small text + logo), the Discover hub keeps glitching and showing only the text.

Clearlogo works fine elsewhere in the Skin (like Spotlight or Widgets), but the Discover hub doesn't work well.

Expected Behavior

Clearlogo applied throughout the skin.

Steps To Reproduce

Set Title Clearlogo to Crop and Text settings to either of them

Screenshots and Additional Info

No response

Checklist

jurialmunkey commented 2 weeks ago

Works fine for me. Tried with both settings.

screenshot00594

screenshot00593

screenshot00595

OfficerKD637 commented 2 weeks ago

Sorry! Clearing the TMDb helper cache did the trick.

vella9 commented 2 weeks ago

Sorry! Clearing the TMDb helper cache did the trick.

@OfficerKD637 where can I find this please?

OfficerKD637 commented 2 weeks ago

Sorry! Clearing the TMDb helper cache did the trick.

@OfficerKD637 where can I find this please?

Go to TMDb Helper Settings > Expert > Delete Cache (Under the 'Other' section)

image

Also, just FYI I later figured out that my glitch was actually caused by me trying to decrease the size of font_info_black in the Includes_Font.xml file because the weather on the splash screen always cuts off on the top regardless of what font you use (totally my fault). So, it's better to not touch that file and just add your custom fontsets in the Font.xml file and the skin will scale everything auto-magically haha

vella9 commented 2 weeks ago

Go to TMDb Helper Settings > Expert > Delete Cache (Under the 'Other' section)

I did this tbh but if I search for let's say John Wick, I get some results with clearlogo and some without. Not sure why.

So, it's better to not touch that file

No, I did not touch any skin files

vella9 commented 2 weeks ago

how did you make the text smaller and the Kodi logo in your pic that says searching?

you now have the option to choose. This is located under Settings > Interface > Title text

xyzfre commented 2 weeks ago

how did you make the text smaller and the Kodi logo in your pic that says searching?

you now have the option to choose. This is located under Settings > Interface > Title text

Thank you I didn't see the update this morning. This is awesome. THANK YOU @jurialmunkey for adding this feature ,I love the small text with the Kodi logo

OfficerKD637 commented 2 weeks ago

Go to TMDb Helper Settings > Expert > Delete Cache (Under the 'Other' section)

I did this tbh but if I search for let's say John Wick, I get some results with clearlogo and some without. Not sure why.

So, it's better to not touch that file

No, I did not touch any skin files

Hmm that's weird. Once I reverted to the original Includes_Font.xml file, everything seemed to fix itself. If it's a similar kind of bug, I can reopen this issue so you can continue the conversation with Jurial. Can you also please try to recreate the issue and post the log and some screenshots?

vella9 commented 1 week ago

Can you also please try to recreate the issue and post the log and some screenshots?

@OfficerKD637 I took a video of this issue that I am experiencing as per below. Sorry for the delay.

https://streamable.com/f0e82d

As you can see, some of the items are not showing the clearlogo and even the background image, but this is not occuring for all of the items. When I checked the artwork for a specific movie that was not showing the clearlogo and the background image, I noticed that these are populated within the manage artwork>select artwork section, they are just not showing somehow.

Do you have any idea what is wrong here? Can you maybe try and replicate the same from your end please? To see if it occurs as well. Thank you

vella9 commented 1 week ago

Go to TMDb Helper Settings > Expert > Delete Cache (Under the 'Other' section)

I presume then you need to select "Delete TMDB Cache" right? This is what I had deleted but the issue persisted.

OfficerKD637 commented 1 week ago

@vella9 Hi! Glad to see you're back!

Maybe try deleting all the caches (TMDb, Fanart TV, OMDB, Item Details, Trakt) and then reloading the skin to see if it works?

Also, try doing a fresh install of the skin again from the repo. No need to delete the skin. It'll simply overwrite your current files (and retain your setups since it won't touch your skinvariables folder) and maybe repair any corrupted files?

If these steps don't work, I can re-open this issue because Jurial might be better equipped to assist you.

vella9 commented 1 week ago

Maybe try deleting all the caches (TMDb, Fanart TV, OMDB, Item Details, Trakt) and then reloading the skin to see if it works?

I tried this and it worked at first, but then the same issue occurred within minutes. I also tried and reinstalled v0.7.25 but the same occurred.

However I noticed this morning that this is only occurring on my test system (windows). So I tried and restored to the same build I use on my live system (android) and the same issue occurred. I checked the logs and I have errors related to TMDBh as per extract. Maybe you can take a look please. It is related to cache but I don't know what I can do in this case.

TIA @OfficerKD637!

OfficerKD637 commented 1 week ago

Hi! Sorry that didn't work out.

I think that error occurs when the skin cannot find the specific image file it's trying to look for. I am not exactly sure if that's what is causing your particular issue but let's try doing the following steps as a last resort:

After deleting the caches, go to the Thumbnails folder and make sure all the images are actually deleted (check all the subfolders like crop_v2, blur_v2, folders 0 to 9, etc.).

Then go to your 'Database' folder and delete Textures13.db Now go inside the database_v6 folder and delete all the database (.db) files.

Restart Kodi

This is probably very overkill but I'm hoping when Kodi has to rebuild it's texture databases, it would fix any corrupted ones that might be causing any conflicts.

At this point I am just guessing everything, so I am re-opening this issue because @jurialmunkey is much better equipped at helping you solve this.

Sorry I couldn't be of much help.

vella9 commented 1 week ago

Hi! Sorry that didn't work out.

I think that error occurs when the skin cannot find the specific image file it's trying to look for. I am not exactly sure if that's what is causing your particular issue but let's try doing the following steps as a last resort:

After deleting the caches, go to the Thumbnails folder and make sure all the images are actually deleted (check all the subfolders like crop_v2, blur_v2, folders 0 to 9, etc.).

Then go to your 'Database' folder and delete Textures13.db Now go inside the database_v6 folder and delete all the database (.db) files.

Restart Kodi

This is probably very overkill but I'm hoping when Kodi has to rebuild it's texture databases, it would fix any corrupted ones that might be causing any conflicts.

At this point I am just guessing everything, so I am re-opening this issue because @jurialmunkey is much better equipped at helping you solve this.

Sorry I couldn't be of much help.

This worked!

One of the above suggestions must have fixed the issue. After following all of the above, the issue is no longer present.

Thank you @OfficerKD637

OfficerKD637 commented 1 week ago

That's great! Glad it got fixed. I'm closing the issue now but if this re-appears please let me know.

jurialmunkey commented 1 week ago

I think that error occurs when the skin cannot find the specific image file it's trying to look for. I am not exactly sure if that's what is causing your particular issue but let's try doing the following steps as a last resort:

Nothing to do with the skin. Skin's don't "find" images. All rendering is handled by Kodi.

error : CImageLoader::DoWork - Direct texture file loading failed for special://masterprofile/Thumbnails/f/f5e62e1e.png

This type of error occurs when Kodi looks-up its image cache database (Textures.db) to see if it has already downloaded and cached an image, but when it tries to access the associated disk location it finds that the file no longer exists.

Usually this happens because a user deleted part or all of their Thumbnails folder without also cleaning the associated entries from Kodi's Texture database which stores the cached location of thumbnails.

Often this is due to some poorly designed "maintenance" addon and bad advice on the internet about needing to "clean" Kodi regularly (you shouldn't be doing this). It's bad practice to be deleting thumbnails cache unless you have severe disk space issues as it wastes server resources of these free APIs by forcing images to be redownloaded all the time (Trakt specifically stopped providing image access via its API for this reason in 2016...)

The other way it might happen is if you copied the Textures.db from one device to another as some attempt at backup without also copying the Thumbnails directory -- because then the associated thumbnails obviously no longer exist. Basically it creates a situation where Kodi thinks it already downloaded the image because the entry for the url is in the cache database but it cant render the image because it doesn't exist at the disk location it should be..

One of the above suggestions must have fixed the issue. After following all of the above, the issue is no longer present.

It will be due to deleting Textures.db from Kodi which then forces recaching of all images. If you are deleting this file, you should also delete your Thumbnails folder as none of these images will be valid anymore.

Maybe try deleting all the caches (TMDb, Fanart TV, OMDB, Item Details, Trakt) and then reloading the skin to see if it works?

You shouldn't be doing this unless TMDbHelper reports a database error indicating corruption in one of these databases (i.e. continual error messages about accessing the specific database). These do not hold local file locations. These only store online metadata to avoid redownloading data unnecessarily.

If you need to refresh details for an item in TMDbHelper, there is a "refresh details" context menu entry. Additionally, if you need to refresh artwork there is also one for that.

OfficerKD637 commented 1 week ago

Thank you so much for the detailed response Jurial. And I apologize to you and @vella9 for my previous replies trying to solve the problem. I was trying to throw everything at it to see what sticks instead of a more technical and methodical approach. And yes I agree that one shouldn't be needlessly deleting caches/thumbnails. My advice was for a 'last resort' scenario but I forgot to mention deleting the Textures13.db file in my original comment.

So I'm assuming, if a similar problem pops up in the future the first course of action should be deleting the Thumbnails folder and then the Textures13.db file?

Again, my apologies to both of you. This would have probably been fixed much quicker if I had tagged Jurial much earlier in the thread.

jurialmunkey commented 1 week ago

So I'm assuming, if a similar problem pops up in the future the first course of action should be deleting the Thumbnails folder and then the Textures13.db file?

It depends on the problem.

error : CImageLoader::DoWork - Direct texture file loading failed for special://masterprofile/Thumbnails/f/f5e62e1e.png

This error indicates that Kodi looked up an image in Textures.db but couldn't find the corresponding image in Thumbnails folder.

Ideally, instead of nuking the entire thing, you should clean the broken entries from the cache database. This can be done with the Texture Cache Maintenance utility: https://kodi.wiki/view/Texture_Cache_Maintenance_utility

There is an exe version for Windows in this post on the forums: https://forum.kodi.tv/showthread.php?tid=158373&pid=3184117#pid3184117

error : CImageLoader::DoWork - Direct texture file loading failed for resource://resource.images.studios.coloured/Westbrook Studios.png

This is a different (though similar) type of error which can be ignored. The skin has told Kodi to use a studio image which doesn't exist in the resource pack so Kodi is logging that fact. Since skins can't check if files exists, these types of errors are fairly common to see and can be safely ignored.

You can determine the difference by looking at the location being accessed. Thumbnails in master profile is location of cached images.

vella9 commented 1 week ago

Often this is due to some poorly designed "maintenance" addon

Then this was the culprit. I do have a "maintenance" addon, but I only use it to backup/restore builds normally. However this week, I did in fact perform a "clean cache" command. So this is what created the issue.

The other way it might happen is if you copied the Textures.db from one device to another

Not in this case this time. However thank you for pointing this out.

It will be due to deleting Textures.db from Kodi which then forces recaching of all images. If you are deleting this file, you should also delete your Thumbnails folder as none of these images will be valid anymore.

Noted, thank you!

I apologize to you and @vella9 for my previous replies trying to solve the problem.

No apologies needed, @OfficerKD637. I appreciate you helping me out. Thanks for your assistance.

Ideally, instead of nuking the entire thing, you should clean the broken entries from the cache database. This can be done with the Texture Cache Maintenance utility: https://kodi.wiki/view/Texture_Cache_Maintenance_utility

There is an exe version for Windows in this post on the forums: https://forum.kodi.tv/showthread.php?tid=158373&pid=3184117#pid3184117

Will give this a go if I encounter any similar issues in the future.

Thank you for everything and for the detailed information provided @jurialmunkey. Really appreciated.