jurialmunkey / skin.arctic.fuse

Other
143 stars 21 forks source link

:bug: Title and background display bug in the Info page when autoplay trailer is enabled #981

Open OfficerKD637 opened 1 week ago

OfficerKD637 commented 1 week ago

Skin section

Widgets

Current Behavior

Hi J!

Hope you're doing well!

This weird bug just started after today's update.

If you have the Autoplay Info Trailers enabled and you go to the 'Info' page of an item from the Discover hub, you'll notice the 'Searching...' text pop behind the movie title for a second just as the trailer starts.

Also, the loading widget placeholders pop in behind all the info as if two windows are being superimposed on top of each other.

This behavior is only unique to the Discover/Search hub. When I tried going to Info page from a widget in my home screen, everything worked perfectly.

Expected Behavior

Info trailer from the Discover hub working like it used to (No 'Searching...' text or 'Placeholders' behind the window)

Steps To Reproduce

  1. Enable Autplay trailers in Info
  2. Go to the Info page of an item from the Discover hub
  3. Wait for the trailer to start

Screenshots and Additional Info

Bug Example 1

Checklist

OfficerKD637 commented 6 days ago

Proposed Fix: I added a !Window.IsVisible(DialogVideoInfo.xml) inside the <visible> conditions of 'Widget_Busy' and "Info_Title_LogoLabel" (the one with $LOCALIZE[31272]...) in Includes_Search_View.xml

<include name="Search_View_Widgets_NoResults">
    <control type="group">
        <include content="Widget_Busy">
            <param name="label">$INFO[Container(5099).ListItem.Label]</param>
            <param name="visible">[$EXP[Search_View_IsUpdating] + !Window.IsVisible(DialogVideoInfo.xml)]</param>
            <height>divider_bottom</height>
            <bottom>46</bottom>
            <left>200</left>
        </include>
    </control>

and then here

    <control type="grouplist">
        <left>view_side</left>
        <right>view_side</right>
        <top>view_top</top>
        <bottom>view_pad</bottom>
        <orientation>vertical</orientation>
        <visible>[$EXP[Search_View_IsUpdating] + !Window.IsVisible(DialogVideoInfo.xml)]</visible>
        <control type="group">
            <height>120</height>
            <include content="Info_Title_LogoLabel">
                <param name="label">$LOCALIZE[31272]...</param>
                <param name="wrapmultiline">false</param>
                <param name="visible">true</param>
                <param name="width">info_plot_w</param>
                <param name="height">132</param>
                <param name="colordiffuse">main_fg</param>
            </include>
        </control>

This seems to visually 'fix' the problem but I think doesn't solve the core issue.

Let me know what you think.