search

jurialmunkey / skin.arctic.horizon

A simple minimal skin for Kodi
Other
174 stars 49 forks source link

[Request] Buttons Fullscreen widget #258

Open rijsab opened 4 years ago

rijsab commented 4 years ago

have more buttons available for Fullscreen widget. Now showing Browse, More Information but perhaps show same buttons as in Info dialogue?

SerpentDrago commented 4 years ago

One thing I think would be very very cool is to have customizable buttons , just like widgets kinda , where you could set a custom action when clicked . Obviously there would have to be a max amount hard set or alignment / space issues would happen .

also customizable buttons for the info page as well , in skin GUI easy to edit custom actions for them .

SerpentDrago commented 4 years ago

@jurialmunkey can you think of any way to add this (custom action buttons ) for both info widgets and Info page . obviously the amount a user could add or customize would have to be limited .

I think this would be a killer feature , and would be ALL i would need to completely switch over . but i get if it would be a lot of work for prob limited usage by most users .

DaisyF8 commented 4 years ago

I found this Issue because I missed a "Watchlist +" button in a Showcase Hub, which shows movies from trakt lists. It would be nice if, when I go into "More Information", there was a button there to add the movie to my watchlist.

drinfernoo commented 4 years ago

@jurialmunkey What if the "action buttons" in the fullscreen widget and/or info dialog were simply (I hope that's simple enough 😅) their own "submenu" of shortcuts, similar to the built-in skin search?

In this way, users could define their own buttons (I think that's kind of the goal here) in those places, with default ones being available for the most common actions.

What do you think?

SerpentDrago commented 4 years ago

or better yet , even default ones could be removed or configured , with option to restore default off course

jurialmunkey commented 4 years ago

I found this Issue because I missed a "Watchlist +" button in a Showcase Hub, which shows movies from trakt lists. It would be nice if, when I go into "More Information", there was a button there to add the movie to my watchlist.

@DaisyF8 - If the item has ListItem.Property(tmdb_id) set then the info dialog actually already shows an add to watchlist button. This property is set for all TMDbHelper items. I should be able to expand this out using TMDbHelper service monitor to grab the ID for items that don't have it set.

jurialmunkey commented 4 years ago

@jurialmunkey What if the "action buttons" in the fullscreen widget and/or info dialog were simply (I hope that's simple enough 😅) their own "submenu" of shortcuts, similar to the built-in skin search?

What do you think?

If only it were that simple...

Take a look at the onclick conditions for the play button or the overview button for an understanding of why this is no simple task.

For the fullscreen widget there are special onleft/right actions needed to control the widget. Also each button needs its own unique ID per main menu item (so potentially 50x IDs). Also, the fullscreen widget needs to send focus to the list first in order to do any actions on it.

There's also the issue that onclick actions and button labels/icons often need to be conditionally responsive to different properties of the listitem (e.g. whether browse or play is displayed depends on whether ListItem.IsCollection or ListItem.IsFolder booleans are true).

Honestly it is a huge amount of work to achieve for minimal benefit and what will ultimately result in people breaking things and then coming on the forums asking why everything is broken.

jurialmunkey commented 4 years ago

With that said, I'm not opposed to having a few optional standardised buttons between the default play and info buttons.

For instance, have a settings dialog similar to the ones for ratings/lists/indicators where various optional buttons such as "trailer" or "overview" or "search" can be toggled. That's something manageable/workable. Having a skinshortcuts free-for-all is not 😅

Custom actions could also be possible - though these would probably only be useful in info dialog where referencing a specific container ID is not necessary to get details about the listitem.

jurialmunkey commented 4 years ago

^^^ That will give basic ability to choose the buttons in the info dialog. I'm using this as a test run before expanding it into other areas.

Please if everyone could test that would be greatly appreciated! "Skin Settings > Lists and other > Customise info dialog buttons"

You should be able to change the three buttons between "Play/Browse" and "Manage". Can't customise/disable those two buttons because they are needed for various things in the skin.

I'd also like to hear some suggestions for the types of buttons that they'd like to have as options. Currently options are: Search, Trailer, Overview, UserRating, Watchlist, None.