jurialmunkey / skin.arctic.horizon

A simple minimal skin for Kodi
Other
174 stars 49 forks source link

Request: Last.fm Love button #265

Open dm2912 opened 4 years ago

dm2912 commented 4 years ago

I play all my music through Kodi on various devices. Is there any chance we can have the Last.fm Love button added to audio media.

looking at Ronie's git it appears as simple as

info for skinners: - if a song can be loved, you can use this visible condition to display the love button:

Window(Home).Property(LastFM.CanLove)

add this onclick action to the love button:

RunScript(service.scrobbler.lastfm,action=LastFM.Love)

jurialmunkey commented 4 years ago

Does this still work? Are there other skins that have working lastfm buttons? Only reason I ask is because I thought the last fm functions were removed a while ago - but maybe it was just that they were separated out from the core modules and moved into their own separate addon.

Happy to add it if you know that it works.

dm2912 commented 4 years ago

Its a separate addon maintained by Ronie https://forum.kodi.tv/showthread.php?tid=195597&highlight=service.scrobbler.lastfm

it seems that the only skin that has a love button at the moment is Transparency but just tested in that and works

image

image

dm2912 commented 4 years ago

If it helps, just did a quick grep scan for lastfm in transparency skin. it appears only in musicOSD.xml

<control type="button" id="919">
                    <description>Last.fm love</description>
                    <width>60</width>
                    <height>60</height>
                    <label>-</label>
                    <font>-</font>
                    <texturenofocus>osd-love-nofocus.png</texturenofocus>
                    <texturefocus>osd-love-focus.png</texturefocus>
                    <onclick>RunScript(service.scrobbler.lastfm,action=LastFM.Love)</onclick>
                    <visible>!String.IsEmpty(Window(Home).Property(LastFM.CanLove))</visible>
                </control>

so it is just two lines that Ronie says to include