jurialmunkey / skin.arctic.horizon

A simple minimal skin for Kodi
Other
175 stars 49 forks source link

[Bug] Widget information displays info from widget above #325

Closed DaisyF8 closed 3 years ago

DaisyF8 commented 3 years ago

I just discovered the "Display Info" setting for widgets. Very noice.

A very minor nitpick in a very specific situation:

on my screen in order Widget A Trakt Next Episode with "Display Info" unchecked Widget B Watchlist with "Display info" checked

See picture... Widget B "Display Info" field will display info for active item in widget A (be it without extra art from OMDb if there is any).

screenshot004

jurialmunkey commented 3 years ago

Nothing can be done about this as kodi doesn't provide any controls to skins for positioning widget items in a group list on screen - it just has some basic logic about position that in some instances I can use some sizing hacks to get it to behave how I want but in this instance it is difficult.

Since depending on which way you scroll the info might appear on screen due to the next widget being position by kodi at the top rather than bottom, then I decided it was better to have the info panel adapt to whatever widget us focused on screen. Originally it was tethered to that one particular widget but I found it really confusing to have info for some other item that wasn't even on screen.

The best thing to do is to put widgets with info at the top of the group and widgets without info below - basically widget with info is two rows high so it always takes full position on screen, whereas a normal widget is only one row so it is positioned at bottom or top by kodi depending on which way you scroll (basically kodi just tries to get the widget on screen when you scroll to it but it only cares that it is on screen and doesn't give any control to the skin over where it is positioned)

DaisyF8 commented 3 years ago

In that case (Info adapts to focused widget - which is totally fine and logical) it appears the art doesn't get fetched if it relates to the widget above. (And I admit, putting double row widgets on top makes the problem go away without solving it, but I think the solution to what I'm flagging is trivial.)

In the screenshots both widgets top and bottom are TmdbHelper Next Up.

screenshot006

Bottom widget gets art, while top widget doesnt for the same show.

screenshot007

jurialmunkey commented 3 years ago

The main problem is that with the widget templates, each widget is only really able to check whether itself is focused or not. It can't check which particular other widget has focus in terms of where it is relative to itself or the screen.

So the choice here is either show art only when self is focused, or always show art. Retrieving the correct art is relatively trivial, it is the visibility condition that is the problem.

I go with showing the art only when focused because I don't want art to appear in the partially offscreen top row -- e.g. imagine in your first pic you scroll one more down, the clearart will now be aligned with the clock but it will be the art for the bottom row because that is what is focused. It gets really annoying and off putting with it changing whilst scrolling.

DaisyF8 commented 3 years ago

Yes, it would become distracting.

Also thanks for explaining with so much detail. I'd rather understand something instead of just accepting it, and you always make sure the first is possible.

[Solved]