search

jurialmunkey / skin.arctic.horizon

A simple minimal skin for Kodi
Other
175 stars 49 forks source link

[Request] Clearlogo/Art on OSD #379

Open unkn0wn234 opened 3 years ago

unkn0wn234 commented 3 years ago

would u consider adding an option to display clearart on the OSD on the right side? or maybe clearlogo in the topleft or right how it is in the default skin for Kodi?

Fatal-Errol commented 3 years ago

I managed to do this by modifying 1080i/Includes_Images.xml and 1080i/Includes_OSD.xml

See my code diff here: https://github.com/jurialmunkey/skin.arctic.horizon/compare/matrix...Fatal-Errol:osd-improvements#diff-8f30dae4fbf4ddccc124041312053d9527fce0b6de35e450c07e3f429476c13f

If it is something that @jurialmunkey would like, then I can send a PR for it but I think he wants to make this skin simple.

unkn0wn234 commented 3 years ago

I managed to do this by modifying 1080i/Includes_Images.xml and 1080i/Includes_OSD.xml

See my code diff here:

https://github.com/jurialmunkey/skin.arctic.horizon/compare/matrix...Fatal-Errol:osd-improvements#diff-8f30dae4fbf4ddccc124041312053d9527fce0b6de35e450c07e3f429476c13f

If it is something that @jurialmunkey would like, then I can send a PR for it but I think he wants to make this skin simple.

Thank you I'm definitely gonna try it out! I noticed u have some other branches too like clear logo fallback, and clear logo in landscape overlay could u explain a bit what they are?

I assume clearlogo will be shown in the widget views and inside addons when there's no clear art? Is there an option to change it to default to clearlogo instead?

Fatal-Errol commented 3 years ago

I managed to do this by modifying 1080i/Includes_Images.xml and 1080i/Includes_OSD.xml See my code diff here: matrix...Fatal-Errol:osd-improvementsdiff-8f30dae4fbf4ddccc124041312053d9527fce0b6de35e450c07e3f429476c13f If it is something that @jurialmunkey would like, then I can send a PR for it but I think he wants to make this skin simple.

Thank you I'm definitely gonna try it out! I noticed u have some other branches too like clear logo fallback, and clear logo in landscape overlay could u explain a bit what they are?

I assume clearlogo will be shown in the widget views and inside addons when there's no clear art? Is there an option to change it to default to clearlogo instead?

For the fallback, yes correct but no config to change it. The landscape clearlogo will show for episode landscape view much like in auramod. I don't want to add more unrelated comments to this issue so feel free to comment on the forked repo instead.

unkn0wn234 commented 3 years ago

I managed to do this by modifying 1080i/Includes_Images.xml and 1080i/Includes_OSD.xml See my code diff here: matrix...Fatal-Errol:osd-improvementsdiff-8f30dae4fbf4ddccc124041312053d9527fce0b6de35e450c07e3f429476c13f If it is something that @jurialmunkey would like, then I can send a PR for it but I think he wants to make this skin simple.

Thank you I'm definitely gonna try it out! I noticed u have some other branches too like clear logo fallback, and clear logo in landscape overlay could u explain a bit what they are? I assume clearlogo will be shown in the widget views and inside addons when there's no clear art? Is there an option to change it to default to clearlogo instead?

For the fallback, yes correct but no config to change it. The landscape clearlogo will show for episode landscape view much like in auramod. I don't want to add more unrelated comments to this issue so feel free to comment on the forked repo instead.

Thanks I will but you have issues disabled on your repo so I cant comment on it!

Fatal-Errol commented 3 years ago

I managed to do this by modifying 1080i/Includes_Images.xml and 1080i/Includes_OSD.xml See my code diff here: matrix...Fatal-Errol:osd-improvementsdiff-8f30dae4fbf4ddccc124041312053d9527fce0b6de35e450c07e3f429476c13f If it is something that @jurialmunkey would like, then I can send a PR for it but I think he wants to make this skin simple.

Thank you I'm definitely gonna try it out! I noticed u have some other branches too like clear logo fallback, and clear logo in landscape overlay could u explain a bit what they are? I assume clearlogo will be shown in the widget views and inside addons when there's no clear art? Is there an option to change it to default to clearlogo instead?

For the fallback, yes correct but no config to change it. The landscape clearlogo will show for episode landscape view much like in auramod. I don't want to add more unrelated comments to this issue so feel free to comment on the forked repo instead.

Thanks I will but you have issues disabled on your repo so I cant comment on it!

Oops sorry, it's turned on now.

computechnopro commented 3 years ago

So, the issue isn't solved yet?. I like the clear art/logo feature from Aura. Missing in AH is such a bummer!