search

juriansluiman / SlmGoogleAnalytics

A ZF2 module to track pages, events and ecommerce transactions with Google Analytics
Other
40 stars 20 forks source link

analytics.js #29

Closed snapshotpl closed 10 years ago

snapshotpl commented 10 years ago
juriansluiman commented 10 years ago

This looks awesome!

Let me check the code furthermore before I merge :)

juriansluiman commented 10 years ago

@snapshotpl I will review shortly. As I see it now, there are a few issues I commented on left. But most is now done, thanks a lot!

juriansluiman commented 10 years ago

@snapshotpl Can you please review the following items, then we're OK to merge:

juriansluiman commented 10 years ago

Thanks for all the work @snapshotpl ! I will tag this as a beta release so people can test it and so on. The docs needs to be updated and I'll have a look to refactor the tests so all universal code is tested too. Then I can tag this 1.4.0 :)