search

juriansluiman / SlmGoogleAnalytics

A ZF2 module to track pages, events and ecommerce transactions with Google Analytics
Other
40 stars 20 forks source link

Feature/displayfeatures 2 #37

Closed basz closed 10 years ago

basz commented 10 years ago

see https://github.com/juriansluiman/SlmGoogleAnalytics/pull/36

juriansluiman commented 10 years ago

@basz thanks for the update. I went through the code and noticed two small details. Can you update them? I'll merge the PR and release another beta (v0.4.0-beta2)

juriansluiman commented 10 years ago

Bas: sorry, the code example for the HEREDOC was wrong; this is why Travis failed (I love tests!)

Google analytics has the scheme/domain https://ssl vs http://www. Double-click requires https:// or http://. Perhaps we have to introduce "sudomain" variables, or dump the complete 'https://' : 'http://') + 'stats.g.doubleclick.net/dc.js' and 'https://ssl' : 'http://www') + '.google-analytics.com/ga.js' in a variable.

basz commented 10 years ago

I just forgot to update the tests... I think we can just remove the ssl. and www. subdomains for ga.js. They will load as expected- (ssl.stats.g.doubleclick.net and www.stats.g.doubleclick.net won't). What do you you think, will Google ever stop serving without the ssl/www subdomains?

juriansluiman commented 10 years ago

I just double-checked the files: all are the same (http://www + http:// + https://ssl + https://) so I guess we just could remove the subdomains. If you can fix the tests I'll merge.

juriansluiman commented 10 years ago

I released beta2, this included this PR

basz commented 10 years ago

thanks jurian