search

juriansluiman / SlmGoogleAnalytics

A ZF2 module to track pages, events and ecommerce transactions with Google Analytics
Other
40 stars 20 forks source link

support for tracking across (sub)domains #9

Closed basz closed 12 years ago

basz commented 12 years ago

enables support for _setDomainName and _setAllowLinker properties

juriansluiman commented 12 years ago

Can you add unit tests for the output? I want to make sure that if you set the domain name or allow linker, it output is correctly set. As an example, you can look how the output of an event is tested.

Also, it looks to me if you set a domain name, you want to set the linker. If you unset the domain name, you want to unset the linker again. Is that correct? If so, you might want to remove the allowLinder setters and just render the line "_gaq.push(['_setAllowLinker'], true);\n" inside your $tracker->getDomainName() check.