StandardClient()->protected function getTag(DOMNode $node, $tag) triggers notice when action is cancelled

juriansluiman / SlmIdealPayment

Payment module for Dutch iDEAL payments

Other

9 stars 5 forks source link

StandardClient()->protected function getTag(DOMNode $node, $tag) triggers notice when action is cancelled #16

Closed japaveh closed 11 years ago

japaveh commented 11 years ago

When an iDeal transaction is cancelled, the XML return is different and does not contain all the parsed tags. This causes a PHP Notice in the getTag parser

[Mon Aug 26 22:42:49 2013] [error] [client <>] PHP Notice:  Trying to get property of non-object in /var/www/ewk/vendor/slm/ideal-payment/src/SlmIdealPayment/Client/StandardClient.php on line 307

The parser needs to be slightly updated or not be applied when the action is cancelled

juriansluiman commented 11 years ago

@japaveh can you test this branch? I don't have this module enabled in a current project.

juriansluiman commented 11 years ago

Tested now, this patch fixes the issue.