search

juriansluiman / Soflomo-Mail

Module to to ease the use of sending e-mail messages in Zend Framework 2
Other
5 stars 8 forks source link

Bring zf3 support #6

Closed basz closed 7 years ago

basz commented 8 years ago

@Danielss89 I see the tests aren't running. Is that something you can fix?

Danielss89 commented 7 years ago

Hm, as this is not an organization, i actually can't do anything on travis :/ So @juriansluiman will have to get the tests going again. I think it happened when the repo was moved from the Soflomo organization to Jurians private account.

basz commented 7 years ago

That ok. Im using the fork atm. Actually forgot i did a stil open PR

Danielss89 commented 7 years ago

Ok, basz, so this is actually working? I can merge?

basz commented 7 years ago

yes it works. Please do if you can, I thought it was abandoned as jurian has moved on to other things

basz commented 7 years ago

Configuration: /Users/bas/Sandbox/Soflomo-Mail/phpunit.xml

................................................ 48 / 48 (100%)

Time: 1.46 seconds, Memory: 10.00MB

OK (48 tests, 112 assertions)

Danielss89 commented 7 years ago

Any breaking changes? man. 6. mar. 2017 kl. 22.50 skrev Bas Kamer notifications@github.com:

yes it works. Please do if you can, I thought it was abandoned as jurian has moved on to other things

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/juriansluiman/Soflomo-Mail/pull/6#issuecomment-284544695, or mute the thread https://github.com/notifications/unsubscribe-auth/AAmofHUWg2JOkDTYKDVOyh-jpTpZDCAgks5rjH-RgaJpZM4Jvaaq .

basz commented 7 years ago

hmm. no more php5.3 min php56

think that's it

Danielss89 commented 7 years ago

I will tag new release later today

basz commented 7 years ago

hm, it seems https://packagist.org/packages/soflomo/mail isn't updating either... that's problematic