search

juribeparada / MMDVM_HS

MMDVM HotSpot: firmware for ZUMspot or MMDVM_HS based boards (D-Star, DMR, YSF, P25, NXDN and POCSAG)
GNU General Public License v2.0
345 stars 141 forks source link

PA5 defined twice #129

Open dave31418 opened 3 years ago

dave31418 commented 3 years ago

I may be reading the code wrong, but it appears in version 1.5.2 in the file Arduino.cpp that PA5 is defined both on line 42 as PIN_TXD2 and then again on line 55 as PIN_POCSAG_LED. I found this just reading the code so I may not be tracing the execution correctly. But on the surface this doesn't appear correct.

juribeparada commented 3 years ago

You are right and that double definition is incorrect. This didn't produce a problem, probably due to most of people are using the "make" command in Linux to build the firmware, or they simply use the binary form. IOArduino.cpp is used when you compile with the Arduino IDE + STM32duino. It will be fixed.