search

jurismarches / luqum

A lucene query parser generating ElasticSearch queries and more !
Other
188 stars 40 forks source link

Support for Python2 #18

Closed erlichmen closed 6 years ago

erlichmen commented 6 years ago

Convert yield from with plain for loop with yield

alexgarel commented 6 years ago

Hello, if we are to support python2.7, tests should pass in python2.7 which is not the case with your patch. Would you mind trying to correct it ? (you should add a - "2.7" in .travis.yml file to see it happen). You can also check locally using make tests

erlichmen commented 6 years ago

I must admit that I didn't do a full py2 support just the above case, I will try to see how much work is it to support py2 across the board.

alexgarel commented 6 years ago

hello @erlichmen I close this PR, for a python 2 support ask more work and the use of six.

A real contribution in this sense would be welcome, but on our side we don't have enough free energy to do it, for now.