search

jurismarches / luqum

A lucene query parser generating ElasticSearch queries and more !
Other
187 stars 42 forks source link

Remove the SEPARATOR token? #47

Closed huntfx closed 4 years ago

huntfx commented 4 years ago

I don't know much about yacc, but I've been putting up with this warning each time I use luqum (I presume you already know it):

WARNING: Token 'SEPARATOR' defined, but not used
WARNING: There is 1 unused token

According to this stackoverflow question, the guy with a similar issue just removed the token from the list and it was fine.

Doing that fixed the warning for me, so I'm wondering if there's a particular reason you are keeping the SEPARATOR token? If it's genuinely not used, shouldn't it be removed from the source code?

alexgarel commented 4 years ago

Hi @Peter92 this is a good Idea. I may handle that later, but PR is always welcome :-)