search

jurismarches / luqum

A lucene query parser generating ElasticSearch queries and more !
Other
188 stars 40 forks source link

Remove unused SEPARATOR token #48

Closed huntfx closed 4 years ago

huntfx commented 4 years ago

Thought I may as well do the PR mentioned in #47 as it was quite simple :)

I removed it from parsetab.py too for the sake of keeping things clean, though I'm aware that the file is auto generated.

alexgarel commented 4 years ago

@Peter92 doctest are failing ! This is due to the Illegal character ' ' error log.

huntfx commented 4 years ago

Ah my bad, it was working fine on my own project so I didn't run the tests after cleaning up the last few references. I'll take it as a learning experience to always run them if available haha.

coveralls commented 4 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling f3310959a6a66667d9d547c42cda8541355618af on Peter92:master into 8a526acef9e95f62353f353b152141edf26b94d1 on jurismarches:master.

coveralls commented 4 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling f3310959a6a66667d9d547c42cda8541355618af on Peter92:master into 8a526acef9e95f62353f353b152141edf26b94d1 on jurismarches:master.

huntfx commented 4 years ago

Appears to be fine now aside from a random error

alexgarel commented 4 years ago

Ok, thanks. For the failing test, we shall drop python3.4 support I guess.