search

jurismarches / luqum

A lucene query parser generating ElasticSearch queries and more !
Other
187 stars 42 forks source link

Unknown item type Phrase during LuceneCheck #94

Closed SleepyMorpheus closed 1 year ago

SleepyMorpheus commented 1 year ago

Hi, When running the script below, i expect the LuceneCheck to report no error as the query is (as far as I can tell) supported by the lucene standard. 

from .parser import parser
from .check import LuceneCheck
from .tree import SearchField, Phrase

query1 = (SearchField("f", Phrase('"Foo Bar"')))
check = LuceneCheck()
print(repr(query))
print(check.errors(query))

But I am presented with the following error

['Unknown item type Phrase : "Foo Bar"']

I couldn't find any check_phrase function in the LueceneCheck class in the check.py file. Is this intended or how could this be fixed? My guess would be to add something like the following to allow phrases but I'm really not sure about this. Any recommendations or ideas?

def check_phrase(self, item, parents):
        if not item.value.endswith('"') or not item.value.startswith('"'):
            yield "Phrase value must start and end with double quote"
SleepyMorpheus commented 1 year ago

whoops, duplicated