search

juristr / webpack-typescript-starter

A simple Webpack 2 + TypeScript starter
126 stars 49 forks source link

feat: add basic karma infrastructure #6

Closed frederikprijck closed 7 years ago

frederikprijck commented 7 years ago

Closes: #1

juristr commented 7 years ago

LOL, can't keep up with that speed, got work to do LOL. Awesome man. Maybe we should also change the .travis.yml s.t. it executes the test as well now. Just to see whether the setup works properly :+1:

frederikprijck commented 7 years ago

Consider that done.

frederikprijck commented 7 years ago

Oops. Karma is watching the tests. Sorry!

frederikprijck commented 7 years ago

I've modified karma.config to not watch the tests.

juristr commented 7 years ago

I've modified karma.config to not watch the tests.

yep :smile: was just about to write you that :wink:

frederikprijck commented 7 years ago

Do you want me to add a test script to watch for code changes aside from the npm test being used by ci ? Should we add tslint for karma aswell? Or only use tsling by calling npm run build(:prod)?

frederikprijck commented 7 years ago

@juristr What do we do with the above comments ?

juristr commented 7 years ago

Ya, I'd add a script that watches, like

"test.watch": ....

and leave npm test to be run by the CI container, thus only as single run. thx