search

jurmous / etcd4j

Java / Netty client for etcd, the highly-available key value store for shared configuration and service discovery.
Apache License 2.0
267 stars 83 forks source link

Fix hiding all request exceptions except ReadTimeoutException #109

Closed msiedlarek closed 7 years ago

msiedlarek commented 8 years ago

I don't know what was the reason by this condition, but it has hidden a runtime exception in my application (due to a dependency conflict) and made the client-side of the promise just inexplicably hang. This gave me some great asynchronous debugging time, but I'd rather not repeat that experience.

lburgazzoli commented 8 years ago

Any change to add also a test case ? if possible btw

lburgazzoli commented 7 years ago

@msiedlarek any chance to have a test case ?

msiedlarek commented 7 years ago

I'm sorry, but to be honest I doubt I'll have time for it in the nearest future. I think the test case would be trivial though - just throw any exception except ReadTimeoutException and see if it was handed down to the promise (it should be after this patch).