search

jurmous / etcd4j

Java / Netty client for etcd, the highly-available key value store for shared configuration and service discovery.
Apache License 2.0
267 stars 83 forks source link

etcd APIv3 support #115

Closed halacs closed 7 years ago

halacs commented 8 years ago

It would be nice to support etcd API v3. Thanks.

lburgazzoli commented 8 years ago

I'm looking at v3 api but it may take a little time, any help would be really appreciated

xiang90 commented 8 years ago

We are trying to collaborate on a v3 java implementation here: https://github.com/coreos/jetcd.

Any help would be highly appreciated!

jurmous commented 8 years ago

A http/2 and protobuf api would mean an almost complete rewrite of all code. We are currently opening a connection per request and it would mean we need to switch to a channel pooled implementation but that means a lot of assumptions need to be removed from the channel handlers.

I then prefer to support this new coreos backed api and apply the learned lessons there.

@xiang90 what are your plans with the new client and how can we help?

lburgazzoli commented 8 years ago

@jurmous agree making etcd4j v3 ready would be an huge effort so working on an "official" java client is the way to go imho

xiang90 commented 8 years ago

@jurmous

The v3 client in coreos repo is a community effort. I am trying to coordinate people, and help on the interface design (to make it not super diverged from the go impl) and answer questions. My hope is to have 1 feature completed, general purpose java client with better community support.

I am going to write about some things we learned from go client implementation and some implementation considerations over the weekend.

lburgazzoli commented 7 years ago

v3 API will be implemented in https://github.com/coreos/jetcd