Trying to connect to an invalid socket/port comibnation and using 'watch' functionality stack overflow

[sheinbergon]

Hi

Due to a configuration issue back at our we tried to connect to an invalid etcd port and watch a directory. In such a scenario , the class EtcdResponsePromise get method creates what will eventually become a stack overflow :

  @Override public T get() throws IOException, EtcdException, EtcdAuthenticationException, TimeoutException {
    if (!waitForPromiseSuccess()) {
      return this.get();
    }

    if (response != null) {
      return response;
    } else {
      if (this.exception instanceof EtcdException) {
        throw (EtcdException) this.exception;
      } if (this.exception instanceof EtcdAuthenticationException) {
        throw (EtcdAuthenticationException) this.exception;
      } else if (this.exception instanceof IOException) {
        throw (IOException) this.exception;
      } else if (this.exception instanceof io.netty.handler.timeout.TimeoutException) {
        throw new TimeoutException();
      } else {
        throw new IOException(this.exception);
      }
    }
  }

Basically waitForPromiseSuccess returns false and get is called again . The external watchRequest is never notified of error due to the way your underlying code , and were are left with ever increasing stack for the threads in question

Actual output from a threaddump running on my machine

    at mousio.etcd4j.promises.EtcdResponsePromise.get(EtcdResponsePromise.java:59)
    at mousio.etcd4j.promises.EtcdResponsePromise.get(EtcdResponsePromise.java:59)
    at mousio.etcd4j.promises.EtcdResponsePromise.get(EtcdResponsePromise.java:59)
    at mousio.etcd4j.promises.EtcdResponsePromise.get(EtcdResponsePromise.java:59)
    at mousio.etcd4j.promises.EtcdResponsePromise.get(EtcdResponsePromise.java:59)
    at mousio.etcd4j.promises.EtcdResponsePromise.get(EtcdResponsePromise.java:59)
    at mousio.etcd4j.promises.EtcdResponsePromise.get(EtcdResponsePromise.java:59)
    at mousio.etcd4j.promises.EtcdResponsePromise.get(EtcdResponsePromise.java:59)
    at mousio.etcd4j.promises.EtcdResponsePromise.get(EtcdResponsePromise.java:59)
    at mousio.etcd4j.promises.EtcdResponsePromise.get(EtcdResponsePromise.java:59)
    at mousio.etcd4j.promises.EtcdResponsePromise.get(EtcdResponsePromise.java:59)
    at mousio.etcd4j.promises.EtcdResponsePromise.get(EtcdResponsePromise.java:59)
    at mousio.etcd4j.promises.EtcdResponsePromise.get(EtcdResponsePromise.java:59)
    at mousio.etcd4j.promises.EtcdResponsePromise.get(EtcdResponsePromise.java:59)
    at mousio.etcd4j.promises.EtcdResponsePromise.get(EtcdResponsePromise.java:59)
    at mousio.etcd4j.promises.EtcdResponsePromise.get(EtcdResponsePromise.java:59)
    at mousio.etcd4j.promises.EtcdResponsePromise.get(EtcdResponsePromise.java:59)
    at mousio.etcd4j.promises.EtcdResponsePromise.get(EtcdResponsePromise.java:59)
    at mousio.etcd4j.promises.EtcdResponsePromise.get(EtcdResponsePromise.java:59)
    at mousio.etcd4j.promises.EtcdResponsePromise.get(EtcdResponsePromise.java:59)
    at mousio.etcd4j.promises.EtcdResponsePromise.get(EtcdResponsePromise.java:59)
    at mousio.etcd4j.promises.EtcdResponsePromise.get(EtcdResponsePromise.java:59)
    at mousio.etcd4j.promises.EtcdResponsePromise.get(EtcdResponsePromise.java:59)
    at mousio.etcd4j.promises.EtcdResponsePromise.get(EtcdResponsePromise.java:59)
    at mousio.etcd4j.promises.EtcdResponsePromise.get(EtcdResponsePromise.java:59)
    at mousio.etcd4j.promises.EtcdResponsePromise.get(EtcdResponsePromise.java:59)
    at mousio.etcd4j.promises.EtcdResponsePromise.get(EtcdResponsePromise.java:59)
    at mousio.etcd4j.promises.EtcdResponsePromise.get(EtcdResponsePromise.java:59)
    at mousio.etcd4j.promises.EtcdResponsePromise.get(EtcdResponsePromise.java:59)
    at mousio.etcd4j.promises.EtcdResponsePromise.get(EtcdResponsePromise.java:59)
    at mousio.etcd4j.promises.EtcdResponsePromise.get(EtcdResponsePromise.java:59)
    at mousio.etcd4j.promises.EtcdResponsePromise.get(EtcdResponsePromise.java:59)
    at mousio.etcd4j.promises.EtcdResponsePromise.get(EtcdResponsePromise.java:59)
    at mousio.etcd4j.promises.EtcdResponsePromise.get(EtcdResponsePromise.java:59)

[lburgazzoli]

Is still happening ? If yes, any chance to have a test case so I can look @ it ?

[sheinbergon]

@lburgazzoli don't know , will try and check against snapshot next week and I'll let you know

[lburgazzoli]

etcd4j 2.13.0 has been released, do you mind testing against this ?

[sheinbergon]

@lburgazzoli Sure. I'll test in the next couple of days and let you know