search

jurmous / etcd4j

Java / Netty client for etcd, the highly-available key value store for shared configuration and service discovery.
Apache License 2.0
267 stars 83 forks source link

testHealth hangs in TestFunctionality #131

Closed jurmous closed 7 years ago

jurmous commented 7 years ago

Run testHealth in TestFunctionality and it hangs with etcd 3.0.13 and 2.3.7.

lburgazzoli commented 7 years ago

Any specific thing to do? because it does not hang for me

sheinbergon commented 7 years ago

@jurmous anything I can do to help ?

sheinbergon commented 7 years ago

@jurmous @lburgazzoli which branch should I test against

lburgazzoli commented 7 years ago

master

sheinbergon commented 7 years ago

@jurmous @lburgazzoli I've tested locally on both etcd 2.3.7 with 3.0.13 ( downloaded from cores etcd github repo ) and couldn't reproduce either. All tests have passed for both cases

I'm testing using Netbeans ( gradle daemon version is 3.1 from what I see ) Go Lang version is 1.6.3 JDK version is 1.8.0_111 OS version is Xubuntu 16.04 LTS

Looking at the testHealth and judging by the symptoms, it's sounds kind of similar to what happens in 2.12.0 and that's due to bad netty version/behavior. Which is weird, because the netty version has been upgraded.

@jurmous are you able to constantly reproduce the issue ?

sheinbergon commented 7 years ago

@lburgazzoli @jurmous what's going on? I understand you're busy and everything, but why aren't you at least responding ?

lburgazzoli commented 7 years ago

@sheinbergon I do not know what is taking @jurmous away from the project but he should have some valid reason so be patient.

I can't release new versions, this is something in @jurmous hands so again be patient.

sheinbergon commented 7 years ago

@lburgazzoli OK, thanks for responding

lburgazzoli commented 7 years ago

@sheinbergon I've pushed a new snapshot with the latest dependencies and moved reconnection to use Netty's event loop instead of a timer, any test would be really helpful.

sheinbergon commented 7 years ago

@lburgazzoli thanks. I didn't get it. Do you want me to test the SDK or write a test scenario myself?

lburgazzoli commented 7 years ago

Just test if it works as expected in your application, looking for regressions. If you have time and want to submit a PR with a test case for re-connection, it would be really appreciated.

sheinbergon commented 7 years ago

Could you please point to your changes/specific commits ?

lburgazzoli commented 7 years ago

https://github.com/jurmous/etcd4j/commit/b842194a1bee2d0700cc5f814453ebc6b1301431

sheinbergon commented 7 years ago

@lburgazzoli OK. I'll try and have a look next week

lburgazzoli commented 7 years ago

@sheinbergon have you had any time to check it ?

lburgazzoli commented 7 years ago

etcd4j 2.13.0 has been released, should be available soon on maven central