search

jurmous / etcd4j

Java / Netty client for etcd, the highly-available key value store for shared configuration and service discovery.
Apache License 2.0
267 stars 83 forks source link

Utils for Json Serialization #168

Closed ghost closed 6 years ago

ghost commented 6 years ago

Improvement from #167

This feature allows to put json format data into etcd, as well as receive it in that same format

dgutierrez-stratio commented 6 years ago

Hi! We have refactored this PR too, let us know if you need any help whatsoever!

lburgazzoli commented 6 years ago

Can you squash it ?

dgutierrez-stratio commented 6 years ago

Sure! Thanks for your time!

dgutierrez-stratio commented 6 years ago

All set. BTW, I'm including new features in JSON deserialization (restoring primitive types and arrays for instance). But I'm not done yet, do you mind if we push these improvements in a further PR?

lburgazzoli commented 6 years ago

that's fine with me, can you just have a look at travis build that fails ?

dgutierrez-stratio commented 6 years ago

It seems that certain operations with EtcdClient freeze when no connection can be stablished to etcd. Since PRs do not launch dockers, that might be the problem. I'm going to set a timeout for these tests so any further PR won't fail.

dgutierrez-stratio commented 6 years ago

Would it be possible to configure Travis for dockerTest task on PRs?

lburgazzoli commented 6 years ago

Ah yeah, can you tweak this condition to run docker also for pr ? https://github.com/jurmous/etcd4j/blob/master/build.gradle#L26

dgutierrez-stratio commented 6 years ago

Sure, I'm not familiar with Travis, shall I remove isPR from the condition? That would imply snapsnot releases. Is it ok if I do that?

lburgazzoli commented 6 years ago

better if we do not upload snapshots for prs

dgutierrez-stratio commented 6 years ago

Done! should I squash both commits?

lburgazzoli commented 6 years ago

Merged :)

dgutierrez-stratio commented 6 years ago

Pleasure collaborating with you!