search

jurmous / etcd4j

Java / Netty client for etcd, the highly-available key value store for shared configuration and service discovery.
Apache License 2.0
267 stars 83 forks source link

Etcd client impl #51

Closed lburgazzoli closed 8 years ago

lburgazzoli commented 9 years ago

I've renamed EtcdClientImpl to EtcdClientTransport as the suffix Impl usually mean a concrete implementation whereas here it was used to define an interface. As consequence, EtcdNettyClient and EtcdNettyConfig have also been renamed to EtcdNettyTransport and EtcdNettyTransportConfig.

I do not know if you like it but IMHO, it makes things a little clearer, if there is something you'd like me to change, let me know.

jurmous commented 9 years ago

I like the better names but I cannot accept it since the classes are of public use and then people their code is invalid when they update if they do any custom Netty config changes. (Regard any class or method mentioned in the README as public) Maybe we can do it when etcd 3.0 api is coming out and more incompatibility changes are probably needed to the API itself. But now I have to maintain stability to the API.

lburgazzoli commented 9 years ago

Make sense.

What about creating an etc4j v3.0 branch or vice versa a v2.x one?