jurmous / etcd4j

Java / Netty client for etcd, the highly-available key value store for shared configuration and service discovery.
Apache License 2.0
267 stars 83 forks source link

Jackson Object Mapper #67

Closed lburgazzoli closed 8 years ago

lburgazzoli commented 8 years ago

Hi @jurmous ,

as the number of decoders is growing and write them is just a very manual task, would you mind if I switch to Jackson Object Mapper ? I know we already had this discussion but now that the messages we support is growing I think the advantages outcome the small issues it adds (dependencies, maybe slower parsing)

jurmous commented 8 years ago

What would be the consequence to the API? Can that be maintained to be backward compatible?

lburgazzoli commented 8 years ago

API won't change, if they do, I'll give up

jurmous commented 8 years ago

Well the decoders are indeed growing more than expected. Go ahead :)

lburgazzoli commented 8 years ago

ok, I'll come back soon

jurmous commented 8 years ago

Merged in https://github.com/jurmous/etcd4j/pull/69