search

jurmous / etcd4j

Java / Netty client for etcd, the highly-available key value store for shared configuration and service discovery.
Apache License 2.0
267 stars 83 forks source link

Added gettter to support using etcd4j client as dependency in unit test #78

Closed timgesekus closed 8 years ago

timgesekus commented 8 years ago

We do a lot of unit testing and having etcd4j as a dependency renders unit testing nearly impossible. Because of private contructors and using plain fields, that can't be mocked. With added getters, it is as least possible together with powermock to mock an etcd4j client.

lburgazzoli commented 8 years ago

Could you add getters to EtcdVersionResponse too ?

timgesekus commented 8 years ago

Done

lburgazzoli commented 8 years ago

thank you

lburgazzoli commented 8 years ago

thank you

timgesekus commented 8 years ago

Welcome. I love the API. Started a client myself before stumbling over this. Saved me a lot of work.