jurobystricky / Netgear-A6210

AC1200 High Gain WiFi USB Adapter Linux kernel driver
291 stars 153 forks source link

Makefile lacks dkms compatibility #92

Open LorenzHo opened 6 years ago

LorenzHo commented 6 years ago

Hi, thanks for the driver, I love it.

When using it with DKMS in Ubuntu, the driver is built against the currently running kernel release, not the kernel release specified by DKMS in the KERNELRELEASE parameter. When upgrading the driver release, this causes the driver to fail to load in the new kernel, because it is built against the old headers.

`dkms install netgear-a6210/2.5.0

Kernel preparation unnecessary for this kernel. Skipping...

Building module: cleaning build area...(bad exit status: 2) make -j4 KERNELRELEASE=4.13.0-21-generic.....^C `

I believe this is due to the use of uname -r in the Makefile, which is ignoring KERNELRELEASE. I don't know enough about Makefiles to fix it myself, sorry about that.

Cheers, Lorenz

laurencejj commented 6 years ago

Hi, I have the same problem:

Kernel preparation unnecessary for this kernel.  Skipping...

Building module:
cleaning build area....(bad exit status: 2)
make KERNELRELEASE=4.13.0-36-generic.....(bad exit status: 2)
ERROR (dkms apport): binary package for netgear-a6210: 2.5.0 not found
Error! Bad return status for module build on kernel: 4.13.0-36-generic (x86_64)
Consult /var/lib/dkms/netgear-a6210/2.5.0/build/make.log for more information.