search

jurplel / install-qt-action

Install Qt on your Github Actions workflows with just one simple action
MIT License
459 stars 78 forks source link

CI (GitHub Actions): replace the misleading step name "npm run build" #131

Closed pzhlkj6612 closed 2 years ago

pzhlkj6612 commented 2 years ago

Hi.

In the workflow log, we can see the following content:

> (√) Setup up job > (√) Run actions/checkout@v2 > (√) Run actions/setup-node@v1 > (√) npm ci > (√) npm run build > (√) ...

I think "npm run build" is a misleading name because both "npm ci" and "npm run build" are common npm commands. Before viewing the detailed log or the workflow YAML file, other people (e.g., me) may not know that there are two commands have been executed. Then, when they try to build their own iqta, they will encounter "error TS2307: Cannot find module".

bexnoss commented 2 years ago

@pzhlkj6612 may I add "Closes https://github.com/jurplel/install-qt-action/pull/131" to https://github.com/jurplel/install-qt-action/pull/137 to link and auto close this PR?

pzhlkj6612 commented 2 years ago

@pzhlkj6612 may I add "Closes #131" to #137 to link and auto close this PR?

Yes, please.