search

jurplel / install-qt-action

Install Qt on your Github Actions workflows with just one simple action
MIT License
459 stars 78 forks source link

Minor Improvements #132

Closed bexnoss closed 2 years ago

bexnoss commented 2 years ago

These are just some minor improvements:

I also plan to update setup-python once https://github.com/actions/setup-python/pull/326 is merged and released and with it enable noImlicitAny because then there won't be any impicit Anys.

I'm looking into adding an internal cache to this action using https://github.com/actions/toolkit/tree/master/packages/cache as discussed in https://github.com/jurplel/install-qt-action/issues/51

bexnoss commented 2 years ago

I would also like to add Prettier if you're open to it?

bexnoss commented 2 years ago

I added Prettier in https://github.com/jurplel/install-qt-action/pull/134, you can look at how it formats everything there. Please let me know what you think.

bexnoss commented 2 years ago

I've redone everything plus added Prettier here. @actions/setup-python doesn't need a build step anymore because it now provides built files.

bexnoss commented 2 years ago

The latest version of @actions/setup-python uses ncc instead of tsc which bundles everything into one file without exports. This is blocked until @actions/setup-python is downgraded again.

bexnoss commented 2 years ago

Superseded by https://github.com/jurplel/install-qt-action/pull/137