Closed bexnoss closed 2 years ago
so cool, any chance to get this soon?
- uses: actions/setup-node@v1
with:
node-version: '16.x'
Why not use below:
- uses: actions/setup-node@v2
with:
node-version: 'lts/*'
lts/*
Will always use the recent LTS
version when available, can possibly be used in other parts where you make use of nodes
@xavier2k6 while updating to Node 16 the package-lock.json's format was updated which printed info about that process to the log. If a newer Node LTS version has similar info logs those would get printed for every user of this action until it was updated. So I think it would be best to manually update the Node version to reduce noise in the logs.
while updating to Node 16 the package-lock.json's format was updated which printed info about that process to the log. If a newer Node LTS version has similar info logs those would get printed for every user of this action until it was updated. So I think it would be best to manually update the Node version to reduce noise in the logs.
Ok & what about actions/setup-node@v2
suggestion?
Good call, thanks! actions/setup-node@v2
supports caching the NPM dependencies so it'll be faster, too.
@bexnoss actions/setup-node@v3
was actually just released yesterday so check it out/you may want to go with that.
Quick heads up for anyone waiting for this: I talked with @jurplel and they're excited for the internal cache and want to merge this but they don't have time to review at the moment. So some version of this PR will get merged but it might take a while.
I usually don't force push PRs but I asked and was told it's ok. I'm happy with the code as it is right now but if anyone has any suggestions I'd be happy to improve upon it further.
@bexnoss actions/checkout@v3
was released yesterday so check it out.
@bexnoss aqtinstall's v2.0 default py7zr
is >=0.17.0
according to 2.0 setup.cfg
However, I've checked the setup.cfg
from zipped source code
from aqtinstall releases of v2.0.0 -> v2.0.2
& py7zr
remained at previous defaults of >=0.15.1
until v2.0.4
where it now defaults to py7zr>=0.17.0
I'll let it to you if you want to leave the install-qt-action
as-is or change defaults for aqtversion
&py7zr
Note:
Qt 6.2.1
support was added in v2.0.2
any chance to get that merged?
@bexnoss
aqtinstall 2.1.0
officially released reference: aqtinstall releases
It now defaults to py7zr>=0.18.3
gentle ping
The time has come—thank you so much for the contribution, and sorry for the immense inexcusable delay.