search

jurplel / install-qt-action

Install Qt on your Github Actions workflows with just one simple action
MIT License
459 stars 78 forks source link

Module installation for Qt 6 does not work #146

Closed JhnW closed 2 years ago

JhnW commented 2 years ago

Hi. Installing additional modules with this action (I checked it on qtserialport) does not work, the module is not installed and the action fails. I have pre-debugged the cause of this problem. You use aqtinstall as deflaut in versioni 1.2.5. On this version, we get a message about an unknown qt version, for example: "Specified Qt version is unknown: 6.2.4." I checked the latest version 2.1.0 locally - on this version it's okay.

ddalcino commented 2 years ago

You are correct that the default version needs to be updated, since aqtinstall 1.2. is no longer maintained and is affected by many bugs. For now, you will have better luck specifying `aqtversion: “==2.1.”` in your workflow.

JhnW commented 2 years ago

I have already fixed it locally, but thanks for the answer. By the way, putting the version number together with == is not the best thing.

ddalcino commented 2 years ago

By the way, putting the version number together with == is not the best thing.

Care to elaborate? If my reading of PEP 440 is correct, ==2.1.* matches the latest bug fix for version 2.1, meaning you get a consistent interface and the latest updates. PEP440 applies here because this argument is fed directly into pip. Is this not the best thing?

JhnW commented 2 years ago

I mean force to write "==X.Y" in Github Action parameter is not the best way. The required version of apt install should be specified simply as the number X.Y on the action interface. This is a really small syntax thing about the action parameter. Unless the author wanted to allow explicit use of other operators for the required PIP version, but then it is good to mention it in the documentation and perhaps let "==" be omitted when specifying one specific version in the aqtversion parameter.