Can't seem to make action work on windows

[jcelerier]

My workflow is:

  winmvsc:
    name: MSVC
    runs-on: windows-latest
    steps:
      - name: Checkout code
        uses: actions/checkout@v2
        with:
          submodules: 'recursive'

      - name: Install Qt
        uses: jurplel/install-qt-action@v3

It fails in the following way at this action's step (https://github.com/ossia/score/runs/7599290150?check_suite_focus=true)

Run jurplel/install-qt-action@v3
Run actions/setup-python@v4
  with:
    python-version: 3.6.x - 3.11.x
    token: ***
    update-environment: true

Successfully set up CPython (3.10.5)
Error: Can't find 'action.yml', 'action.yaml' or 'Dockerfile' under 'D:\a\score\score\action'. Did you forget to run actions/checkout before running your local action?

[PhysSong]

This line doesn't work due to https://github.com/actions/runner/issues/1348. https://github.com/jurplel/install-qt-action/blob/eb012702bacb4ca52222ec4b11f21cb6a2fc2729/action.yml#L63 Hard-coding repository name and revision like jurplel/install-qt-action/action@v3 should work, but it doesn't sound good.

There are one more issue in v3 branch: node_modules isn't updated properly in the new build. @jurplel

[firewave]

This broke yesterday: https://github.com/danmar/cppcheck/runs/7598647802. It was still working fine the day before: https://github.com/danmar/cppcheck/runs/7592054209.

We have aqtversion fixated to ==2.0.6 since we are also using Qt 6 but removing that seems to have no effect.

It also seems that the configuration for caching it was changed within the same version:

Warning: Unexpected input(s) 'cached', valid inputs are ['dir', 'version', 'host', 'target', 'arch', 'install-deps', 'modules', 'archives', 'cache', 'cache-key-prefix', 'setup-python', 'tools', 'set-env', 'tools-only', 'aqtversion', 'py7zrversion', 'extra']

This is super bad since it will break existing usage and should have required a version bump to v4 since it is essentially an API change.

[jurplel]

I never considered v3 released and i didn’t know it was in use to this extent. I will fix this asap.

On Mon, Aug 1, 2022 at 00:49 Oliver Stöneberg @.***> wrote:

This broke yesterday: https://github.com/danmar/cppcheck/runs/7598647802. It was still working fine the day before: https://github.com/danmar/cppcheck/runs/7592054209.

We have aqtversion fixated to ==2.0.6 since we are also using Qt 6 but removing that seems to have no effect.

It also seems that the configuration for caching it was changed within the same version:

Warning: Unexpected input(s) 'cached', valid inputs are ['dir', 'version', 'host', 'target', 'arch', 'install-deps', 'modules', 'archives', 'cache', 'cache-key-prefix', 'setup-python', 'tools', 'set-env', 'tools-only', 'aqtversion', 'py7zrversion', 'extra']

This is super bad since it will break existing usage and should have required a version bump to v4 since it is essentially an API change.

— Reply to this email directly, view it on GitHub https://github.com/jurplel/install-qt-action/issues/153#issuecomment-1200841368, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACRYMFVPHNCVSHCLQQGT7EDVW56RDANCNFSM55FC2LAQ . You are receiving this because you were mentioned.Message ID: @.***>

[firewave]

I never considered v3 released and i didn’t know it was in use to this extent. I will fix this asap.

I wasn't aware v3 was not released yet. Thanks for looking into it.

I think the "problem" was that although the documentation stated v2 at the top, the cache example did use v3...

Maybe you could issue a warning in future dev versions. That will show a notification in the actions overview. Or use a different branch. Or both. :-)

BTW Thanks for making the caching easier.

[jcelerier]

thanks ! for reference I just copied the code at the top of the README which has

- name: Install Qt
  uses: jurplel/install-qt-action@v3

[Jnesselr]

I thought V3 was released as of #119, and this definitely broke our pipelines as well across all OS installs.

[xiaoyifang]

https://github.com/jurplel/install-qt-action/issues/159

[jurplel]

Is there any value in keeping the old cache option besides maintaining compatibility? @firewave

Sorry for the confusion and chaos D:

[jurplel]

This line doesn't work due to actions/runner#1348.

https://github.com/jurplel/install-qt-action/blob/eb012702bacb4ca52222ec4b11f21cb6a2fc2729/action.yml#L63

Hard-coding repository name and revision like jurplel/install-qt-action/action@v3 should work, but it doesn't sound good.

There are one more issue in v3 branch: node_modules isn't updated properly in the new build. @jurplel

I think this should be resolved now

[jurplel]

Closing due to inactivity and releasing v3.

[jcelerier]

thanks! just tested and I'm getting a failure a bit further in the action step: https://github.com/ossia/score/runs/7914486202?check_suite_focus=true if you have any idea ?

Here's my workflow : https://github.com/ossia/score/blob/master/.github/workflows/win-builds.yaml#L109

[tooomm]

thanks! just tested and I'm getting a failure a bit further in the action step: ossia/score/runs/7914486202?check_suite_focus=true if you have any idea ?

Here's my workflow : https://github.com/ossia/score/blob/master/.github/workflows/win-builds.yaml#L109

@jcelerier Try using 6.3.* with a globe for the version and you should be good to go. Only defining MAYOR.MINOR for the version does not work as reported in https://github.com/jurplel/install-qt-action/issues/98#issuecomment-1209070596.