search

jurplel / install-qt-action

Install Qt on your Github Actions workflows with just one simple action
MIT License
446 stars 78 forks source link

Update node.js version to 20; update CI dependencies to remove warnings #222

Closed pzhlkj6612 closed 5 months ago

pzhlkj6612 commented 5 months ago

This PR completes #219 and fixes #220 .

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-node@v3, actions/setup-python@v4, ./action. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

MehdiChinoune commented 5 months ago

CI shows many notes about node16, I think It's from https://github.com/jurplel/install-qt-action/blob/master/action/action.yml#L79

pzhlkj6612 commented 5 months ago

CI shows many notes about node16, I think It's from https://github.com/jurplel/install-qt-action/blob/master/action/action.yml#L79

Fixed.

bcmhercun commented 5 months ago

@jurplel

jonathanlinat commented 5 months ago

@jurplel Hey! 👋🏻 Would you be able to merge this soon? TY!

jurplel commented 5 months ago

Thanks for the ping!

xavier2k6 commented 4 months ago

@jurplel Any plans to merge this in to v3 branch & release 3.3.1?

jurplel commented 4 months ago

Will do, there are some test failures on the v3 branch for some reason preventing immediate release

dc6c commented 3 months ago

It looks like the failure is because the installed tools are not in the path in some conditions. Compare the outputs of stage "Test installed tools" for the workflow case "test (ubuntu-22.04, false, true, true, cached)": successful master:

Path: /home/runner/work/install-qt-action/Qt/Tools/QtInstallerFramework/4.6/bin:/home/runner/work/install-qt-action/Qt/Tools/QtCreator/libexec/qtcreator/clang/bin:/home/runner/work/install-qt-action/Qt/Tools/QtCreator/lib/Qt/bin:/home/runner/work/install-qt-action/Qt/Tools/QtCreator/bin:/opt/hostedtoolcache/Python/3.11.8/x64/bin:/opt/hostedtoolcache/Python/3.11.8/x64:/opt/hostedtoolcache/node/20.11.0/x64/bin:/snap/bin:/home/runner/.local/bin:/opt/pipx_bin:/home/runner/.cargo/bin:/home/runner/.config/composer/vendor/bin:/usr/local/.ghcup/bin:/home/runner/.dotnet/tools:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/snap/bin

and failing branch v3:

Path: /opt/hostedtoolcache/Python/3.11.8/x64/bin:/opt/hostedtoolcache/Python/3.11.8/x64:/opt/hostedtoolcache/node/20.11.0/x64/bin:/snap/bin:/home/runner/.local/bin:/opt/pipx_bin:/home/runner/.cargo/bin:/home/runner/.config/composer/vendor/bin:/usr/local/.ghcup/bin:/home/runner/.dotnet/tools:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/snap/bin