search

jurplel / qView

Practical and minimal image viewer
https://interversehq.com/qview/
GNU General Public License v3.0
1.83k stars 114 forks source link

Float on top #677

Open Stolenboot opened 2 months ago

Stolenboot commented 2 months ago

This is a plea to reopen a closed issue: https://github.com/jurplel/qView/issues/350

As I commented in issue #350, making a window float on top using a third-party app is not possible on many versions of MacOS, and is difficult on other MacOS versions. Philosophically, an image viewer doing a slide show works like a video player and it seems natural to me to have this common function built in. Technically, this is also possible in QT: setWindowFlags(Qt::WindowStaysOnTopHint); (Sorry if this is wrong, I have never used the framework.)

Please reconsider, thank you!

jdpurcell commented 2 months ago

I just added a "Keep window on top during slideshow" option in my fork via this commit. If you'd like to try it out you can grab a build artifact (disclaimer: unofficial version; qView's original/primary author has not reviewed these changes). The setting is not enabled by default, you'd have to enable it first.

Stolenboot commented 2 months ago

Thank you very much!!!

The build artifact quit right after launch. The MacOS secure warning (unknown developer) was not displayed so the cause is probably not the code, but the building process. I tried both the modern and legacy MacOS versions.

Anyway, I am very thankful for your work and hope the changes can be merged after reviewing.

jdpurcell commented 2 months ago

That's strange, which version of macOS are you running, and on Intel or Apple silicon?

Stolenboot commented 2 months ago

I am running MacOS 11.6 on an Intel i9 Macbook Pro. qView 6.1 from interversehq.com works fine, FYI.

jdpurcell commented 2 months ago

I was able to reproduce the crash inside a macOS VM, and I believe it's due to a problem with the specific Xcode SDK version used during compilation. The fixed build is available here if you'd like to try it. The regular macOS build supports macOS 11+ by the way; the legacy version is only needed for macOS 10.13-10.15.

Stolenboot commented 2 months ago

Wonderful! It works. I really appreciate your work and help!