search

jurteam / platform

Jur Beta Platform
https://beta.jur.io
0 stars 0 forks source link

TODO Limit the display of comet/sync warning to chrome browser only #117

Open tyagishuchi1 opened 4 years ago

tyagishuchi1 commented 4 years ago

The dApp displays a warning initially recommending users to either use Comet or Sync. Which makes sense in chrome browser but loses it's meaning in the Sync browser.

Expected Behavior

Warning message should only be shown if chrome browser is detected. And should not be shown in the Sync browser.

Current Behavior

Shows the warning message in both the browsers. image

ashishjur commented 4 years ago

@MirelXhafa can you take this issue? The new issue branch you can fork from feature/connex :+1: Once the changes are made, I'll merge the branch in feature/oath-keeper.

marcomarasco commented 4 years ago

@tyagishuchi1 @ashishjur please note that the message appears also when you miss the sign for identification. Is a general message we used in previous version for both: Ask for downloading and tell user to unlock the wallet.

If @lucaydaniel agree we can change the message text only, leaving the implementation as it is.