search

jurteam / platform

Jur Beta Platform
https://beta.jur.io
0 stars 0 forks source link

Add disclaimer to my oaths screen #209

Closed ashishjur closed 4 years ago

ashishjur commented 4 years ago

Expected Behavior

User should be prompted with disclaimer box like how it's on contracts and disputes screens.

Current Behavior

On My Oaths screen, the user is not prompted for disclaimer acceptance.

Steps to Reproduce

Environment: Dev, Temp Server

  1. Open dApp
  2. Go to My Oaths screen by clicking on top nav Oath Keeper
  3. You will not see disclaimer box at the bottom of the screen

Possible Implementation

tyagishuchi1 commented 4 years ago

@ashishjur I am not sure which box is it. However, no box displays on the screen.

Is this the expected behavior? image

ashishjur commented 4 years ago

@tyagishuchi1 yes. That's correct. The commit is not part of the branch which is deployed on the temp server. So you won't be able to see it there. In your local machine you can check in to that commit to see this box.

I think it went into one of the refactoring branches :see_no_evil:. We will have it on the temp server once we merge branches.

tyagishuchi1 commented 4 years ago

@ashishjur Same behavior is required on the Advocates page too. Infact, it would be better if the default state of the modal is open just like in contracts. It is easy to miss otherwise.