search

jurteam / platform

Jur Beta Platform
https://beta.jur.io
0 stars 0 forks source link

Spacing of Menu Items #315

Closed marcomarasco closed 4 years ago

marcomarasco commented 4 years ago

Expected Behavior

Have a style equal and consistent among JBP

Current Behavior

Main menu items are spaced differently

Possible Solution

Use the same padding between menu items

Steps to Reproduce

See attachment

Schermata 2020-07-21 alle 10 22 10
marcomarasco commented 4 years ago

This is something recurring, in ex it was the same also for Oath Keeper

ashishjur commented 4 years ago

Screenshot from 2020-07-22 11-50-44

Cause: Advocate component's label was using same width as OathKeeper component's label. That was adding extra space after word "Advocate".

I've updated the min-width of Advocate component's label to 77px. We can't remove these fixed widths completely as bold and normal font weights change with by bit more than 2px in case of Advocate. This is something we have to consider for every new top navigation component addition.