search

jurteam / platform

Jur Beta Platform
https://beta.jur.io
0 stars 0 forks source link

Component inconsistency - Date Picker #330

Closed ashishjur closed 4 years ago

ashishjur commented 4 years ago

Component inconsistency - Date Picker has a close action. It looks different and sometimes ovelaps with other actions.

Expected Behavior

Date picker component should be able to handle close and dropdown action views at the same time (two actions). It should align well in case there is one or no action.

Current Behavior

  1. Too much gap between close and dropdown action on Disputes screen. Color of the close icon is not $secondary Screenshot from 2020-07-22 17-50-27

  2. Overlaps on the Contracts screen. For dropdown action, it uses caret instead of a triangle. Screenshot from 2020-07-22 17-50-16

ashishjur commented 4 years ago

I've updated the behavior of Datepicker to show a clear icon only when there is content to clear. That way we will not have two actions at the same time. This way, Datepicker is behaving the same everywhere without breaking any layout.