search

jurteam / platform

Jur Beta Platform
https://beta.jur.io
0 stars 0 forks source link

FIX in advocates table sort filter does not toggle properly #360

Open 0xlyd opened 4 years ago

0xlyd commented 4 years ago

Expected Behavior

When I toggle the sort filter to do ASC/DESC instead there is another state where the sorting icon is not rendered. Once I click it should toggle

Current Behavior

After I click on the sorting filter, then I click again (it reverses the order correctly) and with another click the icon disappears

Possible Solution

Once I click on sort it should then toggle between ASC/DESC sorting

Steps to Reproduce

Environment: Temp

  1. Go to My Advocacy page
  2. Click on Total Earned for three times

Detailed Description

Video: https://drive.google.com/file/d/15R20WORp9forvOxni0WivEEjxyl_reM9/view

ashishjur commented 4 years ago

I think this is intended. All sorts have three states

  1. Asc
  2. Desc
  3. Default (could also be unsorted)

The icon doesn't show up in the case of the default sort.

cc @lucaydaniel