Closed mtmsuhail closed 3 years ago
@MirelXhafa @mtmsuhail The commit you referring seems related to a fix for multiple records in Activities, that as been created after JBP Connex migration. Since Activites are triggers for Notifications, in order to handle those properly, Activities should be inserted at the proper moment due several conditions (the ones you see in commit updates).
I'm not sure about it, but until @frugge can have a look at this, you should try to return always a value instead of null
at rest/app/Models/Traits/ActivitiesTrait.php
on line 67
.
Maybe you can return $activityCreated
at line 67
and instead return null
after line 63
(once $activityCreated->delete();
has been deleted)
@mtmsuhail @MirelXhafa @tyagishuchi1 did you have any news on this?
Expected Behavior
The notification email should be sent to the counterparty while creating a contract
Current Behavior
The notification email not sending to the counterparty while creating a contract
Possible Solution
There is no configuration related issues present in
test.jur.io
, The issue seems to be present after the commit ofcef146b
on June 3rd 2020. https://github.com/jurteam/platform/commit/cef146bab711fb9a5c6ffed37a441b8168fe138a#diff-3a328648844ad094660e2be808ea1c2dI am getting emails when I roll back the changes of
rest/app/Models/Traits/ActivitiesTrait.php
.Hint: The code is expecting
status_code
of 36 or 39, but in my case thestatus_code
is 0 or 1