search

jurteam / platform

Jur Beta Platform
https://beta.jur.io
0 stars 0 forks source link

FIX log is undefined in stories #86

Closed ashishjur closed 4 years ago

ashishjur commented 4 years ago

Function log is used in ContractsTable.stories.js but not imported. Also, it's the same issue in 25 more files.

Expected Behavior

The story should render without error.

Current Behavior

Throws log is not defined error.

Possible Solution

Import log from utls/helpers.

Steps to Reproduce

Environment: Dev

  1. npm run storybook
  2. In the browser, visit http://localhost:9009/?path=/story/contractstable--no-contracts

Context (Environment)

Branch feature/connex at commit 9be4bb7.

Possible Implementation

Add import { log } from "../../../utils/helpers"; to ContractTables.stories.js

ashishjur commented 4 years ago

I'm working on similar issues in rest of the stories. Some places it's used in callbacks. I'll keep the log there. In other places where it's just for logging veriable/message, I'll remove the use of log.

frugge commented 4 years ago

@ashishjur pull request #88 is merged into feature/connex