search

juseg / hyoga

Paleoglacier modelling framework
https://hyoga.io
GNU General Public License v3.0
8 stars 0 forks source link

consider using cf_xarray #12

Closed dcherian closed 1 year ago

dcherian commented 3 years ago

I saw your tweet and this looks like a cool project.

cf_xarray should help you remove the CF parsing code, it's intended to allow indexing by standard_name etc. I'd be happy to consider changes that would make its use in this project easier.

juseg commented 3 years ago

Thank you for passing by here and bringing this up! It seems like something I should be using indeed.

juseg commented 1 year ago

Closing this as done (for one year actually). Hyoga will use cf_xarray from the next release v0.1.2. However, the code still relies on internal method getvar for some heuristics, e.g. computing a vector magnitude from its components, or glacier surface altitude as bedrock altitude plus ice thickness.

https://github.com/juseg/hyoga/blob/7e735f948b631f828facbc1b808ac563c181b06b/hyoga/hyoga.py#L231-L304

dcherian commented 1 year ago

Good to hear!