search

jushutch / swiping_card_deck

A widget for swiping through a deck of cards with gestures or buttons.
https://pub.dev/packages/swiping_card_deck
BSD 3-Clause "New" or "Revised" License
13 stars 10 forks source link

Create GitHub Actions workflow to run tests for pull requests #3

Closed jushutch closed 3 years ago

jushutch commented 3 years ago

Create a simple GitHub Action workflow to run the package test suite for every open pull request. A correct workflow should run flutter test for every update on a pull request and block it from being merged if tests fail. The naming of the workflow should be descriptive and concise.

inovaprog commented 3 years ago

Hi, @jushutch, I would like to work on this issue.

jushutch commented 3 years ago

Hi @inovaprog, I'll assign you now, good luck!

inovaprog commented 3 years ago

Thanks, @jushutch . But I think I have to wait for issue #2 to be resolved first.

jushutch commented 3 years ago

Thanks, @jushutch . But I think I have to wait for issue #2 to be resolved first.

You're right because flutter test will fail without any tests. I'll create a single test to prevent that and add a comment here when I'm done with that. In the meantime you should still be able to work on the workflow, it just won't run successfully.

jushutch commented 3 years ago

@inovaprog I just added a passing test so you should be clear to work on this issue 👍🏻

inovaprog commented 3 years ago

Thank you @jushutch . I will work in it now.

inovaprog commented 3 years ago

@jushutch, I submitted the PR #8 . I am available for any necessary changes.