search

jushutch / swiping_card_deck

A widget for swiping through a deck of cards with gestures or buttons.
https://pub.dev/packages/swiping_card_deck
BSD 3-Clause "New" or "Revised" License
13 stars 10 forks source link

Create GitHub Actions workflow to analyze code for pull requests #4

Closed jushutch closed 3 years ago

jushutch commented 3 years ago

Create a simple GitHub Action workflow to run the flutter analyzer for every open pull request. A correct workflow should run flutter analyze for every update on a pull request and block it from being merged if there are any errors or warnings; info messages should not cause the workflow to fail. The naming of the workflow should be descriptive and concise.

inovaprog commented 3 years ago

Hi, @jushutch . I would like to work on it.

jushutch commented 3 years ago

Hi @inovaprog, I'll assign this issue to you now! Let me know if you need any clarifications or run into any issues, and in case you haven't already, make sure to check out the contributing guidelines in CONTRIBUTING.md. Thank you for contributing and happy hacking!

inovaprog commented 3 years ago

Hi, I made the changes but I think I got a little confused when I opened PR. If this is wrong let me know please

inovaprog commented 3 years ago

6 Fixes issues indicated by flutter analyze

jushutch commented 3 years ago

Hi, I made the changes but I think I got a little confused when I opened PR. If this is wrong let me know please

I just saw your PR and I'm reviewing it now, overall it looks great! I'm going to request some small changes and once those are fixed it should be good to merge 👍🏻

inovaprog commented 3 years ago

Thank you @jushutch , if you need I am available to work on this project.

jushutch commented 3 years ago

@inovaprog That's great, you can definitely look at the other issues and claim another one that you're interested in, just like you did for this one, but I'll only assign you to one issue at a time. I'll also be going offline until tomorrow so I won't be able to resolve pull requests until then