search

juspay / fencer

Fencer is a port of https://github.com/lyft/ratelimit into Haskell.
https://hub.docker.com/r/juspayin/fencer
Other
9 stars 2 forks source link

Ensure that Fencer.Proto does not get out of date #70

Closed mdimjasevic closed 5 years ago

mdimjasevic commented 5 years ago

This PR introduces a new stage in the GitLab CI where a Haskell source file is generated from a .proto file. In case this generated file is different from the one that is in Fencer's Git repository, the stage fails and consequently the whole CI build fails.

One downside of the patch is that it increases the CI build time that used to be in the 10-minute range to a 30-minute range. This is due to Nix rebuilding everything for the introduced stage over and over again.

This patch closes #58.

neongreen commented 5 years ago

One downside of the patch is that it increases the CI build time that used to be in the 10-minute range to a 30-minute range.

Ehhh. Okay, let's see what we can do about it.

neongreen commented 5 years ago

Oh!

You forgot to add cachix to the new job you defined, so it can't reuse previously built paths.