Disallow duplicates in configs

juspay / fencer

Fencer is a port of https://github.com/lyft/ratelimit into Haskell.

https://hub.docker.com/r/juspayin/fencer

Other

9 stars 2 forks source link

Disallow duplicates in configs #96

Open neongreen opened 4 years ago

neongreen commented 4 years ago

[x] Duplicate domains are not allowed: https://github.com/lyft/ratelimit/blob/master/test/config/config_test.go#L174-L183
[ ] Duplicate keys are not allowed: https://github.com/lyft/ratelimit/blob/master/test/config/config_test.go#L196-L205 (can use https://hackage.haskell.org/package/yaml-0.11.2.0/docs/Data-Yaml.html#v:decodeFileWithWarnings)

mdimjasevic commented 4 years ago

We have handled the case of duplicate domains. I'll check what is the case with duplicate keys, but my hunch is that such a configuration will give a failure during parsing.