search

juspay / hyper-sdk-react

React Native Plugin over Hyper SDK
https://juspay.in
GNU Affero General Public License v3.0
5 stars 11 forks source link

fix(android): android gradle plugin 8 compatibility #52

Closed vikrantnegi closed 1 month ago

vikrantnegi commented 4 months ago

This is the minimum required change for this module to work on react-native 0.73 which includes android gradle plugin 8

It is backwards compatible with all previous versions of react-native that include android gradle plugin 7 or even 6 and older

nverdhan commented 4 months ago

hey - trying this fix with SDK 34 and RN 0.73,

I keep getting this error when importing import in.juspay.hypersdkreact.HyperSdkReactModule

Expecting qualified name

Does this PR fix the above issue too?

vikrantnegi commented 4 months ago

Yes @nverdhan This add the supports for android API level 34 which is required for gradle 8.

nverdhan commented 4 months ago

Okay - this fix isn't working for us. 

./gradlew --version

------------------------------------------------------------
Gradle 8.3
------------------------------------------------------------

Build time:   2023-08-17 07:06:47 UTC
Revision:     8afbf24b469158b714b36e84c6f4d4976c86fcd5

Kotlin:       1.9.0
Groovy:       3.0.17
Ant:          Apache Ant(TM) version 1.10.13 compiled on January 4 2023
JVM:          18.0.2 (Oracle Corporation 18.0.2+9-61)
OS:           Mac OS X 14.4.1 x86_64

RN version is 0.73.8

===

While the prepaid payment on the app just works well, when we import HyperSdkReactModule in our MainActivity.kt for overriding onRequestPermissionsResult, it doesn't recognise the package and asks for a fully qualified name.

import in.juspay.hypersdkreact.HyperSdkReactModule // this line doesn't work shows error "Expecting qualified name"