Open SamraatBansal opened 1 year ago
While accepting api_key from user in shift4 currently we accept something like Basic c2tfdGVzdF93cjhMYjdqd1FvbwajkhfbQ6.
api_key
Basic c2tfdGVzdF93cjhMYjdqd1FvbwajkhfbQ6
This Basic Keyword should not be there as if we only want to access the value of the key at some other authorization it would be difficult to extract.
The Basic key should be appended in the code like it is done for Bluesnap in bluesnap.rs .
Bluesnap
bluesnap.rs
Since we add Basic at code level we can only expect the actual key in the input from the user, rather than expecting the Basic key along with it.
Basic as keyword needs to be added in the api_key field under connector_account_details in create connector account api
Basic
connector_account_details
No, but I'm happy to collaborate on a PR with someone else
Hi @SamraatBansal, I would like to take this issue. Please assign this to me. I have raised a PR for this - https://github.com/juspay/hyperswitch/pull/1442
Bug Description
While accepting
api_key
from user in shift4 currently we accept something likeBasic c2tfdGVzdF93cjhMYjdqd1FvbwajkhfbQ6
.This Basic Keyword should not be there as if we only want to access the value of the key at some other authorization it would be difficult to extract.
Expected Behavior
The Basic key should be appended in the code like it is done for
Bluesnap
inbluesnap.rs
.Since we add Basic at code level we can only expect the actual key in the input from the user, rather than expecting the Basic key along with it.
Actual Behavior
Basic
as keyword needs to be added in theapi_key
field underconnector_account_details
in create connector account apiHave you spent some time to check if this bug has been raised before?
Have you read the Contributing Guidelines?
Are you willing to submit a PR?
No, but I'm happy to collaborate on a PR with someone else