Open prasunna09 opened 1 year ago
@prasunna09 going to take a look at this by the evening, and will submit it in morning
Then I'll assign this to you! @tusharxoxoxo
what should be done for these currencies whose iso code is missing?
In this issue, do we only need to add the missing currencies in pub enum Currency
or do we also need to implement them with their respective iso_4212 code in the very next function and also the other parts such as pub fn is_three_decimal_currency(self) -> bool {
and pub fn is_zero_decimal_currency
accordingly??
Yes, you have to add all the missing currencies in pub enum currency
and have to add their corresponding iso_4217
codes and also include them in other is_three_decimal_currency(self) -> bool
and pub fn is_zero_decimal_currency
.
There r some currencies which are mentioned in this Wikipedia article List_of_circulating_currencies which r not present in ISO_4217 like, for example, SVC
is not present in the list of currencies, but is present in ISO_4217 list of currencies and vice versa CNY
is present in the list of currencies but is not present in the ISO_4217 list.
HRK
is also not present in ISO_4217 list
There r some currencies which are mentioned in this Wikipedia article List_of_circulating_currencies which r not present in ISO_4217 like, for example,
SVC
is not present in the list of currencies, but is present in ISO_4217 list of currencies and vice versaCNY
is present in the list of currencies but is not present in the ISO_4217 list.
my bad CNY
is present in the list, I don't understand why CNY
is being written in a weird place, it feels completely out of place like all the currencies r written alphabetically but this CNY
is placed at a completely strange place out of alphabetical order
some of the currencies go to the 4 decimal digits so for them should I create a new function or leave them as it is
CLF
there r a lot of currencies that don't have anything in the place decimal row like it's blank, I am treating those blanks as 0
Feature Description
Add missing currencies to Currency enum in enum.rs, since we want descent coverage of the currencies. Reference - https://en.wikipedia.org/wiki/List_of_circulating_currencies
Possible Implementation
Have you spent some time to check if this feature request has been raised before?
Have you read the Contributing Guidelines?
Are you willing to submit a PR?
None